Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve MacroLiveSampleErrors in translated-content (#12578) in ja #17888

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Resolve MacroLiveSampleErrors in translated-content (#12578) in ja #17888

merged 8 commits into from
Jan 18, 2024

Conversation

YujiSoftware
Copy link
Contributor

Description

Motivation

Additional details

#12578 に記載のあった /ja/web/svg/attribute/href/index.md は、ファイルが無くなっていたため対応していません。
それ以外は、すべて最新の英語版に揃えて修正しました。

#17680 に記載しましたが、h4 （#### 見出し）の後に EmbedLiveSample がある場合は見出しと引数の値を揃えないと動きませんので、そこだけ日本語にしています。
（files/ja/web/css/text-combine-upright/index.md が該当します）
それ以外は、英語版そのままで問題ありませんでした。

Related issues and pull requests

Fixes #12578

@YujiSoftware YujiSoftware requested a review from a team as a code owner January 13, 2024 13:34
@YujiSoftware YujiSoftware requested review from dynamis and removed request for a team January 13, 2024 13:34
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Jan 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2024 •
edited
Loading

Preview URLs (13 pages)
Flaws (26)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /ja/docs/Web/SVG/Attribute/onclick
Title: onclick
Flaw count: 6

  • macros:
    • /ja/docs/Web/SVG/Element/marker does not exist but fell back to /en-US/docs/Web/SVG/Element/marker
    • /ja/docs/Web/SVG/Element/style does not exist but fell back to /en-US/docs/Web/SVG/Element/style
    • /ja/docs/Web/SVG/Element/symbol does not exist but fell back to /en-US/docs/Web/SVG/Element/symbol
    • /ja/docs/Web/SVG/Element/textPath does not exist but fell back to /en-US/docs/Web/SVG/Element/textPath
    • /ja/docs/Web/SVG/Element/tref does not exist but fell back to /en-US/docs/Web/SVG/Element/tref
    • and 1 more flaws omitted

URL: /ja/docs/Web/SVG/Attribute/d
Title: d
Flaw count: 7

  • macros:
    • /ja/docs/Web/SVG/Element/glyph does not exist but fell back to /en-US/docs/Web/SVG/Element/glyph
    • /ja/docs/Web/SVG/Element/glyph does not exist but fell back to /en-US/docs/Web/SVG/Element/glyph
    • /ja/docs/Web/SVG/Element/glyph does not exist but fell back to /en-US/docs/Web/SVG/Element/glyph
    • /ja/docs/Web/SVG/Element/missing-glyph does not exist but fell back to /en-US/docs/Web/SVG/Element/missing-glyph
    • /ja/docs/Web/SVG/Element/missing-glyph does not exist but fell back to /en-US/docs/Web/SVG/Element/missing-glyph
  • broken_links:
    • Anchor not lowercase
  • translation_differences:
    • Differences in the important macros (10 in common of 12 possible)

URL: /ja/docs/Web/SVG/Attribute/fill-opacity
Title: fill-opacity
Flaw count: 2

  • macros:
    • /ja/docs/Web/SVG/Element/textPath does not exist but fell back to /en-US/docs/Web/SVG/Element/textPath
    • /ja/docs/Web/SVG/Element/tref does not exist but fell back to /en-US/docs/Web/SVG/Element/tref

URL: /ja/docs/Web/SVG/Attribute/fill
Title: fill
Flaw count: 5

  • macros:
    • /ja/docs/Web/SVG/Element/textPath does not exist but fell back to /en-US/docs/Web/SVG/Element/textPath
    • /ja/docs/Web/SVG/Element/tref does not exist but fell back to /en-US/docs/Web/SVG/Element/tref
    • /ja/docs/Web/SVG/Element/textPath does not exist but fell back to /en-US/docs/Web/SVG/Element/textPath
    • /ja/docs/Web/SVG/Element/tref does not exist but fell back to /en-US/docs/Web/SVG/Element/tref
    • /ja/docs/Web/SVG/Element/tref does not exist but fell back to /en-US/docs/Web/SVG/Element/tref

URL: /ja/docs/Web/SVG/Attribute/marker-mid
Title: marker-mid
Flaw count: 4

  • macros:
    • /ja/docs/Web/SVG/Element/marker does not exist but fell back to /en-US/docs/Web/SVG/Element/marker
    • /ja/docs/Web/SVG/Element/marker does not exist but fell back to /en-US/docs/Web/SVG/Element/marker
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /ja/docs/Web/CSS/text-transform
Title: text-transform
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ja/docs/Web/CSS/text-combine-upright
Title: text-combine-upright
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

(comment last updated: 2024-01-18 12:56:28)

github-actions[bot]
github-actions bot reviewed Jan 13, 2024
View reviewed changes
files/ja/web/svg/attribute/d/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/d/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/d/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/d/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/fill/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/r/index.md Show resolved Hide resolved
files/ja/web/svg/attribute/r/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/r/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/r/index.md Outdated Show resolved Hide resolved
files/ja/web/svg/attribute/r/index.md Outdated Show resolved Hide resolved
mfuji09
mfuji09 requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1件の確認をお願いします。

files/ja/web/svg/attribute/d/index.md Outdated Show resolved Hide resolved
YujiSoftware and others added 5 commits January 17, 2024 19:34
@YujiSoftware
Resolve MacroLiveSampleErrors in translated-content (mdn#12578) in ja
d85fc9a
@YujiSoftware
Resolve mod-linter
bfefa0c
@YujiSoftware @github-actions
Update files/ja/web/svg/attribute/r/index.md
3044a92 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@YujiSoftware @github-actions
Update files/ja/web/svg/attribute/r/index.md
7bd3f7a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@YujiSoftware
Resolve mod-linter
cf95efc
mfuji09
mfuji09 requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません。あと1件見落としていましたので、こちらも修正をお願いします。

files/ja/web/css/text-transform/index.md Outdated Show resolved Hide resolved
mfuji09
mfuji09 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。ありがとうございました。

@mfuji09 mfuji09 merged commit 0ea91a0 into mdn:main Jan 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mfuji09 mfuji09 mfuji09 approved these changes

@dynamis dynamis Awaiting requested review from dynamis dynamis is a code owner automatically assigned from mdn/yari-content-ja

Assignees
No one assigned
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve MacroLiveSampleErrors in translated-content
2 participants
@YujiSoftware @mfuji09